About page: logo-dark is not properly handled
!985 (merged) introduced logo-text
, logo-dark
, and logo-text-dark
variants on the LOGO
field in /usr/lib/os-release
. It seems like the way this is implemented, however, doesn't actually ever look for logo-dark
.
My distro's setup: LOGO=carbon-logo
. I have both carbon-logo
and carbon-logo-dark
in the icon search path. g-c-c shows carbon-logo
in the dark theme
This is currently done by taking the logo name, appending -text
, optionally appending -dark
, and then turning on fallbacks. In my case, fallbacks go like this:
-
carbon-logo-text-dark
: doesn't exist. fallback -
carbon-logo-text
: doesn't exist. fallback -
carbon-logo
: exists. use it.carbon-logo-dark
is completely ignored.
An alternative way to implement this would be using g_themed_icon_new_from_names
and hard-coding the four options g-c-c supports.