Skip to content

event-editor: Hide Cancel & Delete when read-only

Jeff Fortin requested to merge jfft/gnome-calendar:hide_redundant_buttons_in_readonly_event_editor into main

This soft-depends on !418 (merged), as it makes a ton more sense when there is a tooltip explaining what's going on with the read-only status icon.

Update: this now soft-depends on !439 (merged), as it would visually make more sense on top of it.

Before this branch After this branch
before after

This might even indirectly improve accessibility by reducing the amount of unnecessary widgets a screen reader (machine or human) would need to read.

(Note that the fields being editable is a regression, see issue 1178 in the related items in #1168.)

The primary change, besides the small cleanup:

Read-only events show a "Done" button instead of the "Save" button.
The "Done" button does the same thing as "Cancel", so the "Cancel" button is then redundant.

Likewise, it is impossible to delete events from read-only calendars; there is no reason to let users wonder why they can't click "Delete". It is better to explain this in a tooltip on the padlock icon.

Fixes #1168

Potential follow-up: !480

Edited by Jeff Fortin

Merge request reports