Skip to content

event-editor: Introduce reminder at event start time

Dimitrios Christidis requested to merge dchristidis/gnome-calendar:introduce-reminder-at-event-start-time into main

One instance where this can be useful is online meetings. Five minutes prior to the meeting can feel too early. With the URL set in the location, one can click on it when the notification pops up and join right on time.

The label ‘Event start time’ already exists for such reminders. However, it is currently impossible to set one through GNOME Calendar.

Assuming that introducing this option is deemed beneficial, I would like to request some advice on the implementation:

  1. This commit replaces the 0 magic value with G_MAXUINT. Would adding a dedicated boolean found_button variable be better?
  2. In case a button was not found, shouldn’t there be some warning-level log message?

Merge request reports