Event editor dialog's "Done" button appears instead of "Save" for read+write events, and "Save" appears after having viewed a read-only event
We recently discovered that sometimes, the Event editor dialog shows a Save button, and sometimes it shows a Done button.
Narrated video demonstrating the problem and the subtleties of its reproduction: https://youtu.be/b7lGUsI1Kpk
It turns out that, much like an NPC in a dungeon, it only appears when you open a new Event editor dialog after having completed a sidequest to unlock the "Opened a read-only event's event editor dialog (and closed it) for the first time" achievement, before you re-enter the event editor dungeon... so its appearance is effectively "off by one", making it seem like a random encounter with a chaotic element.
Looking at the code and trying to figure out the intent of the set_writable
method, my interpretation is: that button was always meant to say "Save" unless it's a read-only calendar, in which case it would say "Done"... but the if
statement (containing the function return) is not meant to happen before it.
So I'm making a branch to fix this theoretical issue. I wonder why the if
return statement is even there, though.
While I'm at it, I'll also hide the Cancel button for read-only events, because having both a "Cancel" and "Done" button, when the Done button doesn't actually try to save any changes, is kinda nonsensical in that situation.