Setting end time to 23h when start time is 23h should not bump end date to next day until you type an end time after midnight
This is a very minor corner-case scenario, but it causes problems / user inattention errors when scheduling time-based events that last "between 23h00 and 23h59" (ex: a half-hour event at 23h).
To reproduce
- Create an event using the advanced event editor dialog
- Toggle off "All day" to convert to a time-based event
- Type "23" as the starting hour, leave minutes to "00"
- Type "23" as the ending hour (before setting the minutes)
Actual results
End date is bumped 1 day into the future
Expected results
In the very specific case of events that start at 23:xx and end at 23:yy, we should not auto-increment the end time (and thus end date) by 1 hour; we can pretty safely assume the user meant to do a time-based event that is within the same day and that they will set the minutes end time to sometime before 23h59. It is much less likely that the user actually meant to create an event from "23h today to 23h next day".
In other situations (ex: start/end times that are any number other than 23
), GNOME Calendar can safely do its usual calculations to auto-increment the end time by 1 hour after the start time.
This is a successor to issue #91 (closed), and kind of related (but much less messed up) to issue #1120 (12-hour time issue), and #393 (default values issue).