42.alpha: Build time isses
After fixing #250 (closed) I found few other minor issues:
- missing
$(libdir)/girepository-*/*.typelib
Looks like .gir files are installed however I fon't see .typelib files
[tkloczko@ss-desktop usr]$ ls -l lib64 share
lib64:
total 212
lrwxrwxrwx 1 tkloczko tkloczko 19 Jan 11 06:57 libgcalc-2.so -> libgcalc-2.so.1.0.1
-rwxr-xr-x 1 tkloczko tkloczko 173992 Jan 11 06:57 libgcalc-2.so.1
lrwxrwxrwx 1 tkloczko tkloczko 15 Jan 11 06:57 libgcalc-2.so.1.0.1 -> libgcalc-2.so.1
lrwxrwxrwx 1 tkloczko tkloczko 17 Jan 11 06:57 libgci-1.so -> libgci-1.so.0.0.0
-rwxr-xr-x 1 tkloczko tkloczko 23840 Jan 11 06:57 libgci-1.so.0
lrwxrwxrwx 1 tkloczko tkloczko 13 Jan 11 06:57 libgci-1.so.0.0.0 -> libgci-1.so.0
drwxr-xr-x 1 tkloczko tkloczko 36 Jan 11 06:57 pkgconfig
share:
total 0
drwxr-xr-x 1 tkloczko tkloczko 56 Jan 11 06:57 applications
drwxr-xr-x 1 tkloczko tkloczko 16 Jan 11 06:57 dbus-1
drwxr-xr-x 1 tkloczko tkloczko 10 Jan 11 06:57 devhelp
drwxr-xr-x 1 tkloczko tkloczko 40 Jan 11 06:57 gir-1.0
drwxr-xr-x 1 tkloczko tkloczko 14 Jan 11 06:57 glib-2.0
drwxr-xr-x 1 tkloczko tkloczko 32 Jan 11 06:57 gnome-shell
drwxr-xr-x 1 tkloczko tkloczko 146 Jan 11 06:57 help
drwxr-xr-x 1 tkloczko tkloczko 14 Jan 11 06:57 icons
drwxr-xr-x 1 tkloczko tkloczko 474 Jan 11 06:57 locale
drwxr-xr-x 1 tkloczko tkloczko 8 Jan 11 06:57 man
drwxr-xr-x 1 tkloczko tkloczko 64 Jan 11 06:57 metainfo
drwxr-xr-x 1 tkloczko tkloczko 8 Jan 11 06:57 vala
- compile time warning
Extracted from build log:
[98/229] valac -C /home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi/mpfr.vapi /home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi/mpc.vapi --pkg gio-2.0 --color=always --directory gcalc/libmpfrg.a.p --basedir ../gcalc --library mpfrg --header gcalc/mpfrg.h --vapi ../mpfrg.vapi ../gcalc/mpfr-glue.vala
[99/229] /usr/bin/gcc -Igcalc/libmpfrg.a.p -Igcalc -I../gcalc -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -w -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -Os -fPIC -MD -MQ gcalc/libmpfrg.a.p/meson-generated_mpfr-glue.c.o -MF gcalc/libmpfrg.a.p/meson-generated_mpfr-glue.c.o.d -o gcalc/libmpfrg.a.p/meson-generated_mpfr-glue.c.o -c gcalc/libmpfrg.a.p/mpfr-glue.c
[100/229] rm -f gcalc/libmpfrg.a && /usr/bin/gcc-ar csrD gcalc/libmpfrg.a gcalc/libmpfrg.a.p/meson-generated_mpfr-glue.c.o
[101/229] valac -C --pkg gee-0.8 --pkg libsoup-2.4 --pkg libxml-2.0 --pkg posix --pkg gio-2.0 --color=always --directory gcalc/libgcalc-2.so.1.p --basedir ../gcalc --library gcalc-2 --header gcalc/gcalc.h --vapi ../gcalc-2.vapi --gir ../GCalc-2.gir --use-header --vapidir=/home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi --pkg=mpc --pkg=mpfr ../gcalc/gcalc-assign.vala ../gcalc/gcalc-constant.vala ../gcalc/gcalc-division.vala ../gcalc/gcalc-equation.vala ../gcalc/gcalc-equation-manager.vala ../gcalc/gcalc-error-result.vala ../gcalc/gcalc-expression.vala ../gcalc/gcalc-expression-container.vala ../gcalc/gcalc-expression-hash-map.vala ../gcalc/gcalc-function.vala ../gcalc/gcalc-function-acos.vala ../gcalc/gcalc-function-acosh.vala ../gcalc/gcalc-function-asin.vala ../gcalc/gcalc-function-asinh.vala ../gcalc/gcalc-function-atan.vala ../gcalc/gcalc-function-atanh.vala ../gcalc/gcalc-function-cos.vala ../gcalc/gcalc-function-cosh.vala ../gcalc/gcalc-function-exp.vala ../gcalc/gcalc-function-log.vala ../gcalc/gcalc-function-sin.vala ../gcalc/gcalc-function-sinh.vala ../gcalc/gcalc-function-sqrt.vala ../gcalc/gcalc-function-tan.vala ../gcalc/gcalc-function-tanh.vala ../gcalc/gcalc-group.vala ../gcalc/gcalc-hashable.vala ../gcalc/gcalc-math-assign.vala ../gcalc/gcalc-math-binary-operator.vala ../gcalc/gcalc-math-constant.vala ../gcalc/gcalc-math-constant-complex.vala ../gcalc/gcalc-math-constant-number.vala ../gcalc/gcalc-math-division.vala ../gcalc/gcalc-math-equation.vala ../gcalc/gcalc-math-equation-manager.vala ../gcalc/gcalc-math-error-result.vala ../gcalc/gcalc-math-expression.vala ../gcalc/gcalc-math-function.vala ../gcalc/gcalc-math-group.vala ../gcalc/gcalc-math-minus.vala ../gcalc/gcalc-math-multiply.vala ../gcalc/gcalc-math-operator.vala ../gcalc/gcalc-math-parameter.vala ../gcalc/gcalc-math-plus.vala ../gcalc/gcalc-math-polynomial.vala ../gcalc/gcalc-math-pow.vala ../gcalc/gcalc-math-result.vala ../gcalc/gcalc-math-term.vala ../gcalc/gcalc-math-variable.vala ../gcalc/gcalc-minus.vala ../gcalc/gcalc-multiply.vala ../gcalc/gcalc-parameter.vala ../gcalc/gcalc-parser.vala ../gcalc/gcalc-plus.vala ../gcalc/gcalc-polynomial.vala ../gcalc/gcalc-pow.vala ../gcalc/gcalc-result.vala ../gcalc/gcalc-solver.vala ../gcalc/gcalc-term.vala ../gcalc/gcalc-variable.vala gcalc/namespace-info.vala gcalc/mpfrg.vapi
../gcalc/gcalc-parser.vala:76.7-76.20: warning: Switch does not handle `NONE', `EOF' of enum `GCalc.Parser.TokenType'
switch (token) {
^^^^^^^^^^^^^^
../gcalc/gcalc-parser.vala:436.5-436.14: warning: Switch does not handle `EQUAL_SIGN', `RIGHT_PAREN', `ERROR', `LEFT_BRACE', `OCTAL', `IDENTIFIER_NULL', `COMMENT_MULTI', `COMMA', `HEX', `LEFT_CURLY', `SYMBOL', `COMMENT_SINGLE', `LAST', `RIGHT_BRACE', `LEFT_PAREN', `NONE', `RIGHT_CURLY', `BINARY' of enum `GLib.TokenType'
switch (t) {
^^^^^^^^^^
../gcalc/gcalc-parser.vala:489.5-489.14: warning: Switch does not handle `EQUAL_SIGN', `RIGHT_PAREN', `ERROR', `LEFT_BRACE', `OCTAL', `IDENTIFIER_NULL', `COMMENT_MULTI', `COMMA', `HEX', `LEFT_CURLY', `SYMBOL', `COMMENT_SINGLE', `LAST', `RIGHT_BRACE', `LEFT_PAREN', `NONE', `RIGHT_CURLY', `BINARY' of enum `GLib.TokenType'
switch (t) {
^^^^^^^^^^
Command-line option `--use-header` is deprecated and will be ignored
Compilation succeeded - 3 warning(s)
[142/229] valac -C --pkg posix /home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi/mpfr.vapi /home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi/mpc.vapi --pkg libxml-2.0 --pkg libsoup-2.4 --pkg libadwaita-1 --pkg gtksourceview-5 --pkg gtk4 --pkg gobject-2.0 --target-glib ' 2.40.0' --pkg glib-2.0 --pkg gio-2.0 --color=always --directory lib/libcalculator.a.p --basedir ../lib --library calculator --header lib/calculator.h --vapi ../calculator.vapi --target-glib 2.40.0 ../lib/currency.vala ../lib/currency-provider.vala ../lib/equation.vala ../lib/equation-lexer.vala ../lib/equation-parser.vala ../lib/financial.vala ../lib/function-manager.vala ../lib/math-equation.vala ../lib/math-function.vala ../lib/math-variables.vala ../lib/number.vala ../lib/serializer.vala ../lib/unit.vala gcalc/mpfrg.vapi
../lib/equation-parser.vala:1305.5-1305.34: warning: Method `Parser.destroy_all_nodes' never used
private void destroy_all_nodes (ParseNode node)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../lib/number.vala:46.5-46.42: warning: Type `MPFR.Precision' can not be used for a GLib.Object property
public static MPFR.Precision precision { get; set; default = 1000; }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation succeeded - 2 warning(s)
[169/229] valac -C --pkg gee-0.8 --pkg posix /home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi/mpfr.vapi /home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi/mpc.vapi --pkg gobject-2.0 --target-glib ' 2.40.0' --pkg glib-2.0 --pkg gio-2.0 --color=always --directory tests/gcalc-solve-basic.p --basedir ../tests ../tests/gcalc-solving-basic.vala gcalc/gcalc-2.vapi gcalc/mpfrg.vapi
../tests/gcalc-solving-basic.vala:1271.33-1271.60: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1295.33-1295.60: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1307.33-1307.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res2 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1331.33-1331.60: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1343.33-1343.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res2 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1368.33-1368.60: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1380.33-1380.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res2 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1393.33-1393.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res3 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1419.33-1419.60: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1431.33-1431.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res2 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1444.33-1444.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res3 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1470.33-1470.60: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1482.33-1482.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res2 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1495.33-1495.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res3 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1522.33-1522.60: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1534.33-1534.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res2 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1547.33-1547.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res3 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1561.33-1561.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res4 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1585.33-1585.60: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1603.33-1603.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res2 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../tests/gcalc-solving-basic.vala:1616.33-1616.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
warning ("Error: %s", (res3 as ErrorResult).message);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation succeeded - 21 warning(s)
[192/229] valac -C --pkg posix /home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi/mpfr.vapi /home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi/mpc.vapi --pkg libadwaita-1 --pkg gtksourceview-5 --pkg gtk4 --pkg gobject-2.0 --target-glib ' 2.40.0' --pkg glib-2.0 --color=always --directory src/gnome-calculator.p --basedir ../src --gresources=../src/ui/gnome-calculator.gresource.xml --target-glib 2.40.0 --vapidir=/home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/src --pkg config --gresources ../src/ui/gnome-calculator.gresource.xml --vapidir=/home/tkloczko/rpmbuild/BUILD/gnome-calculator-42.alpha/vapi ../src/gnome-calculator.vala ../src/math-buttons.vala ../src/math-converter.vala ../src/math-display.vala ../src/math-preferences.vala ../src/math-popover.vala ../src/math-function-popover.vala ../src/math-variable-popover.vala ../src/math-window.vala ../src/math-history.vala lib/calculator.vapi gcalc/mpfrg.vapi
../src/math-buttons.vala:320.44-320.76: warning: Access to possible `null'. Perform a check or use an unsafe cast.
visible = adv_panel != null && (adv_panel as Adw.Leaflet).folded;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/math-buttons.vala:323.44-323.76: warning: Access to possible `null'. Perform a check or use an unsafe cast.
visible = fin_panel != null && (fin_panel as Adw.Leaflet).folded;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/math-buttons.vala:58.17-58.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
(adv_panel as Adw.Leaflet).visible_child_name = "basic";
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/math-buttons.vala:60.17-60.61: warning: Access to possible `null'. Perform a check or use an unsafe cast.
(fin_panel as Adw.Leaflet).visible_child_name = "basic";
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/math-buttons.vala:552.21-552.65: warning: Access to possible `null'. Perform a check or use an unsafe cast.
(adv_panel as Adw.Leaflet).visible_child_name = converter.view_more_active ? "advanced" : "basic";
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/math-buttons.vala:554.21-554.65: warning: Access to possible `null'. Perform a check or use an unsafe cast.
(fin_panel as Adw.Leaflet).visible_child_name = converter.view_more_active ? "advanced" : "basic";
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/math-buttons.vala:681.9-681.35: warning: Access to possible `null'. Perform a check or use an unsafe cast.
(widget as Gtk.Window).hide ();
^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/math-window.vala:62.9-62.43: warning: Access to possible `null'. Perform a check or use an unsafe cast.
(this as Gtk.Widget).add_controller (event_controller);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../src/math-converter.vala:247.40-247.60: warning: Use of possibly unassigned parameter `source_unit'
out Unit? source_unit,
^^^^^^^^^^^^^^^^^^^^^
../src/math-converter.vala:248.40-248.60: warning: Use of possibly unassigned parameter `target_unit'
out Unit? target_unit)
^^^^^^^^^^^^^^^^^^^^^
Compilation succeeded - 10 warning(s)