Skip to content

intelephense & gvls: Do not replace 'IdeObject.destroy' vfunc

Veli Tasalı requested to merge tasali/gnome-builder:fix-vfunc-destroy-override into main

Hi,

Using IdeObject.do_destroy inside the plugins replaces the Builder's default destroy behavior (ide_object_real_destroy), which then causes an infinite loop when closing projects. With this change, both plugins connect to the destroy signal instead.

This also removes do_parent_set of GVls plugin as it doesn't do anything.

Finally, GVls was attempting to close the IdeLspClient in its destroy method, which was unnecessary, as it can close itself. So, that part was also removed.

Merge request reports