Skip to content

Some shortcuts fixes

Vanadiae requested to merge Vanadiae/gnome-builder:some-shortcuts-fixes into master

It seems there's a few shortcuts (see some examples below, but there are more) that are defined as part of the sourceview bindings even if they aren't related to the sourceview itself, which means they only work when there's a sourceview focused (e.g. won't work in any other page type, like documentation or folder browser). I'm wondering if there's a way of moving all those shortcuts from the .css keybindings files to more appropriate shortcut file (e.g. ide-frame-shortcuts.c) without breaking all the vim/emacs/sublime-text "emulated" shortcuts (since I assume that's why they are here in the first place, e.g. Ctrl+K which is used for something else with the emacs keybindings).

bind "<ctrl>comma" { "action" ("app", "preferences", "") }; in plugins/editor/shared.css

  bind "<ctrl><alt>Page_Up" { "action" ("frame", "previous-page", "") };
  bind "<ctrl><alt>KP_Page_Up" { "action" ("frame", "previous-page", "") };
  bind "<ctrl><alt>Page_Down" { "action" ("frame", "next-page", "") };
  bind "<ctrl><alt>KP_Page_Down" { "action" ("frame", "next-page", "") };

  bind "<ctrl>k" { "action" ("frame", "show-list", "") };

^ in plugins/editor/default.css

It currently means that Ctrl+K will only show the Opened Files popover when the current page is a sourceview, which means I can't reliably use only keyboard to switch between the docs/editor/whatever pages. Same thing with the Preferences shortcut, where you can't open them with the shortcut if the focus is not on an editor/sourceview page, which means you can't open them if you don't have any opened page too.

So maybe there would be a suitable solution for that ?

Merge request reports