Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
gnome-builder
gnome-builder
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 500
    • Issues 500
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 20
    • Merge Requests 20
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gnome-buildergnome-builder
  • Issues
  • #797

Closed
Open
Opened Feb 02, 2019 by nielsle@nielsle

Make libide-lsp send "Initialized" as the second lsp request

If I read the spec correctly the Lsp Client should always send an "Initialized" as the second request to the server. https://microsoft.github.io/language-server-protocol/specification#initialized

However libide doesn't currently send Initialize, and that works fine with lsp-servers such as rls. https://gitlab.gnome.org/GNOME/gnome-builder/blob/master/src/libide/lsp/ide-lsp-client.c#L870

However the lsp-server named rustanalyzer treats initialized as mandarory and fails if the client doesn't send initialized, https://github.com/rust-analyzer/rust-analyzer/blob/master/crates/gen_lsp_server/src/lib.rs#L119

I admit that the spec is a little unclear, but I think that the rust analyzer is correct here. Anyway it could be great to have libide send Initialized so that one can make a rustanalyzer-lsp-plugin.py.

Here are some related issues https://github.com/prabirshrestha/vim-lsp/issues/166 https://github.com/Microsoft/language-server-protocol/issues/180

Edited Feb 02, 2019 by nielsle
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: GNOME/gnome-builder#797