Crash when launching a build terminal, if the flatpak manifest is invalid
To reproduce:
- Create a project with a broken flatpak manifest (e.g. with runtime "org.freedesktop.NotAPlatform")
- Click "New Build Terminal"
- Builder crashes with the following output:
11:25:33.9128 ide-subproces-supervisor[ 2]: TRACE: ENTRY: ide_subprocess_supervisor_start_in_usec():268
11:25:33.9128 ide-subproces-supervisor[ 2]: TRACE: EXIT: ide_subprocess_supervisor_start_in_usec():284
11:25:33.9128 ide-subproces-supervisor[ 2]: TRACE: EXIT: ide_subprocess_supervisor_wait_cb():406
11:25:33.9128 ide-simple-subprocess[ 2]: TRACE: EXIT: ide_simple_subprocess_wait_cb():129
11:25:33.9129 ide-simple-subprocess[ 2]: TRACE: ENTRY: ide_simple_subprocess_finalize():39
11:25:33.9129 ide-simple-subprocess[ 2]: TRACE: EXIT: ide_simple_subprocess_finalize():45
11:25:34.3426 ide-completion[ 2]: TRACE: ENTRY: ide_completion_unblock_interactive():1475
11:25:34.3426 ide-completion[ 2]: TRACE: EXIT: ide_completion_unblock_interactive():1481
sys:1: Warning: g_object_ref: assertion 'G_IS_OBJECT (object)' failed
11:25:34.3448 ide-runtime[ 2]: CRITICAL: ide_runtime_get_name: assertion 'IDE_IS_RUNTIME (self)' failed
11:25:34.3561 ide-workspace[ 2]: DEBUG: Adding IdeTerminalPage to page MRU
**
ide-terminal-launcher:ERROR:../../../../../../../../../Documents/gnome-builder/src/libide/terminal/ide-terminal-launcher.c:331:spawn_runtime_launcher: assertion failed: (IDE_IS_RUNTIME (runtime))
Bail out! ide-terminal-launcher:ERROR:../../../../../../../../../Documents/gnome-builder/src/libide/terminal/ide-terminal-launcher.c:331:spawn_runtime_launcher: assertion failed: (IDE_IS_RUNTIME (runtime))
Expected behavior: "New Build Terminal" should be greyed out, or should fail without crashing.
Builder version: 42.alpha1 (42.alpha1-111-g4d582902d) flatpak-nightly