Skip to content

[gnome-3-32] Don't crash when taking screenshots with GL

Felipe Borges requested to merge dont-crash-screenshots-with-gl-gnome-3-32 into gnome-3-32

Boxes crashes when taking screenshots (calling spice_display_get_pixbuf () when GL (virgl) is enabled. This is a known Mesa issue, reported at https://bugs.freedesktop.org/106811

This fix takes screenshots "client-side", in the widget, instead of asking spice-gtk for a pixbuf (that causes the crash for virgl). That is not a permanent fix because screenshot in the client-side implies that the screenshot is going to have the dimensions and aspect ration of the display widget (consequently the Boxes window).

This commit should be reverted once the issues above are fixed and shipped to users.

The issue has been initially reported as #311 (closed). Fixes #360 (closed) also.

Fixes #397 (closed)

Cherry-picked from 6648a731

Merge request reports