Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 852
    • Issues 852
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !657

socket test: Adjust for Windows-specific sendto() error

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed LRN requested to merge lrn/glib:cherry-pick-b3a55db8 into master Feb 13, 2019
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

With winsock sending messages to NULL results in G_IO_ERROR_NOT_CONNECTED instead of G_IO_ERROR_FAILED. MSDN says: WSAENOTCONN 10057 Socket is not connected. A request to send or receive data was disallowed because the socket is not connected and (when sending on a datagram socket using sendto) no address was supplied. So this is a direct mapping of the implementation error. Covering it up in the wrapper (by converting it to G_IO_ERROR_FAILED) doesn't seem feasible or needed (no one, except for the testsuite, really cares which unrecoverable error is returned by sendto()).

(cherry picked from commit b3a55db8f087c326cb15c09802b19950ca18fb1b)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: cherry-pick-b3a55db8