Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 855
    • Issues 855
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 55
    • Merge requests 55
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !3142

tests/gdbus-method-invocation: Fix missing g_variant_new() argument

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alexander Richardson requested to merge arichardson/glib:varargs-missing-argument into main Dec 15, 2022
  • Overview 6
  • Commits 1
  • Pipelines 2
  • Changes 1

I noticed this when running the test on an Arm Morello system where varargs have bounds. g_variant_new() was trying to read an integer using va_arg(), but since there was no argument it resulted in a bounds errors there. On most other architectures this will just read whatever value is contained in the next argument register and is not something that ASan can detect, so it never resulted in test failures.

Split out from !3135 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: varargs-missing-argument