Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 852
    • Issues 852
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !313

Some cleanups for the netlink GNetworkMonitor

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Iain Lane requested to merge wip/netlink-monitor-cleanups into master Sep 10, 2018
  • Overview 9
  • Commits 4
  • Pipelines 3
  • Changes 2

Here's some cleanups to the netlink monitor that are enough to fix #1518 (closed).

A theory that I have, that I haven't tested, is that the relevant part of e0b120cc that fixes this bug is passing a GError into the initable_init. This means that the bug I'm fixing in 986bb037 was fixed by accident in the 2.58 cycle.

The first two commits (986bb037 and b206ce7e) are bug fixes that are needed here to make the test pass reliably. Not sure why we don't see b206ce7e more often.

I could split 2b0336b4 and 3524817d into another MR if you want. They are for debuggability - it was good when fixing this to be able to see what GIO was doing.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/netlink-monitor-cleanups