Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 853
    • Issues 853
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 54
    • Merge requests 54
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !3113

gaction: Validate actions activated over D-Bus

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge 1904-action-crashes into main Dec 08, 2022
  • Overview 5
  • Commits 9
  • Pipelines 3
  • Changes 11

The action name, parameter and new state are all controlled by an external process, so can’t be trusted. Ensure they are validated before being passed to functions which assert that they are correctly typed and extant.

Add unit tests.

Signed-off-by: Philip Withnall pwithnall@endlessos.org

Closes #1904 (closed)


This is a whole series of commits which make similar changes to all the places where GActions are externally triggered. New unit tests cover everything.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1904-action-crashes