Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 855
    • Issues 855
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 55
    • Merge requests 55
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !2995

Revert !2924 in 2.74.x branch

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Simon McVittie requested to merge wip/smcv/revert-2924 into glib-2-74 Oct 21, 2022
  • Overview 1
  • Commits 3
  • Pipelines 1
  • Changes 2

This returns to the 2.74.0 implementation of hashing 64-bit quantities, which is more prone to collisions on little-endian platforms, but avoids hashing everything to 0 on big-endian (#2787 (closed)).

It also avoids the update to 2.74.1 breaking incorrect code that makes assumptions about hash table traversal order, which seems like something that is fine for a development branch like 2.75.x but less fine for a stable branch that is meant to be bugfix-only.

Resolves: #2787 (closed)


/cc @3v1n0 @pwithnall @wszqkzqk

Alternatively, we could cherry-pick !2994 (merged) to the 2.74.x branch, if people want to keep the reduced collisions and are OK with changing hash table iteration order on a stable branch.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/smcv/revert-2924