Skip to content

tests: Fix incorrect basename comparison in gsubprocess test

Philip Withnall requested to merge wip/pwithnall/more-macos-test-fixes into main

This was causing intermittent failures on macOS, depending on whether the tmpdir ended with a / or /some-dir. g_strrstr() is not the right function to use to extract a basename from a path, for this reason.

When it failed, the macOS test was failing with:

ok 16 /gsubprocess/env
Bail out! GLib-GIO:ERROR:../gio/tests/gsubprocess.c:1507:test_cwd: assertion failed (basename == tmp_lineend_basename): ("/T\n" == "/\n")

The test now passes reliably, which means that it can be removed from the list of expected failures on macOS.

Signed-off-by: Philip Withnall pwithnall@endlessos.org

Helps: #1392

Merge request reports