Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 858
    • Issues 858
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 56
    • Merge requests 56
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !2217

Work around GThreadPool free-function not being reliable on FreeBSD yet

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Simon McVittie requested to merge wip/freebsd-thread-pool-free into main Aug 05, 2021
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1
  • tests: GThreadPool free-function is not reliably called on FreeBSD yet

    This new feature in 2.69.0 does not appear to be reliable on the FreeBSD CI runners. Disable this part of the test while it's investigated, so that we can use CI as an acceptance gate for unrelated branches again.

    Leave it enabled when run with -m thorough so that FreeBSD developers can debug the intermittent failure.

    Mitigates: #2456 (closed)


This is obviously not really desirable, but having CI that we can't reliably use as a gate, because developers mash "Retry" until their unrelated branch accidentally succeeds, doesn't seem great either.

The hack applied here is FreeBSD-specific, so that if the GThreadPool free-function regresses on other platforms like Linux or Windows, our CI gate will still detect that.

Edited Aug 05, 2021 by Simon McVittie
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/freebsd-thread-pool-free