Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 877
    • Issues 877
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 42
    • Merge requests 42
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • GLib
  • Merge requests
  • !2141

Backport !2138 “glocalfileoutputstream: Fix ETag check when replacing through a symlink” to glib-2-68

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Philip Withnall requested to merge pwithnall/glib:backport-2140-file-replace-contents-etags-glib-2-68 into glib-2-68 Jun 07, 2021
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 2

Since commit 87e19535, the ETag check when writing out a file through a symlink (following the symlink) has been incorrectly using the ETag value of the symlink, rather than the target file. This is incorrect because the ETag should represent the file content, not its metadata or links to it.

Fix that, and add a unit test.

Signed-off-by: Philip Withnall pwithnall@endlessos.org

Fixes: #2417 (closed)


Trivial backport of !2138 (merged) (excluding the second commit which was an incidental cleanup) to glib-2-68.

Edited Jun 07, 2021 by Philip Withnall
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: backport-2140-file-replace-contents-etags-glib-2-68