Backport !1187 “Define G_MSVC_SYMBOL_PREFIX correctly for ARM32” to glib-2-64 (!1656) · Merge requests · GNOME / GLib

Philip Withnall requested to merge pwithnall/glib:backport-1187-msvc-arm32-glib-2-64 into glib-2-64 Sep 22, 2020

Symbols on x86 are prefixed with an underscore but symbols on x64/ARM/ARM64 are not.

Relevant information concerning the prefixes for the architectures can be found in the vcpkg project [1,2], where arm and arm64 builds are part of the CI.

Specifically, _WIN64 is defined on Windows ARM64, so this issue is only visible when building on ARM32.

[1] https://github.com/microsoft/vcpkg/blob/08e74979df124d9360343751cefcae615c2ec5ed/ports/glib/fix-arm-builds.patch [2] https://github.com/microsoft/vcpkg/pull/6116

Trivial backport of !1187 (merged) to glib-2-64.

Backport !1187 “Define G_MSVC_SYMBOL_PREFIX correctly for ARM32” to glib-2-64

Merge request reports