Skip to content

Add missing 'extern' to the dllexport version of GLIB_VAR/GOBJECT_VAR

Martin Storsjö requested to merge mstorsjo/glib:fno-common-extern into master

The __declspec(dllexport) attribute in itself doesn't imply 'extern' - thus any intended variable declaration with GLIB_VAR/GOBJECT_VAR would actually be a variable definition. With C compilers defaulting to -fcommon, this isn't an issue, but upcoming compilers (GCC 10 and Clang 11) will default to -fno-common, ending up with duplicate definitions of these variables.

Merge request reports