Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • G GLib
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 858
    • Issues 858
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 56
    • Merge requests 56
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GLib
  • Merge requests
  • !1311

tests: Fix callback arguments in fake-document-portal

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Philip Withnall requested to merge pwithnall/glib:1983-fix-fake-document-portal into master Jan 07, 2020
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

They didn’t match the prototype generated by gdbus-codegen, which meant that the FD list was being iterated incorrectly. Secondly, the document ID list returned by the method was not NULL terminated, which could lead to reading off the end of the list.

Somehow, neither of these bugs caused problems on Linux, but they did cause problems on FreeBSD.

Signed-off-by: Philip Withnall withnall@endlessm.com

Fixes: #1983 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1983-fix-fake-document-portal