ostree tests broken since bfdc5fc4: File '/tmp/test-tmp-libostree_test-basic-user.sh.test-QB4SA0/diff-test2' is not empty
I've not done much besides bisecting yet, but this test in ostree fails for us in Ubuntu since I pushed GLib 2.63.1. Thought I'd report early:
ok diff cwd
-rw-rw-r-- 1 ubuntu ubuntu 536 Nov 8 17:37 /tmp/test-tmp-libostree_test-basic-user.sh.test-XAWQA0/diff-test2
# M /7
# M /four
# M /somelink
# M /a
# M /a/4
# M /a/6
# M /a/nested
# M /a/nested/2
# M /a/nested/3
# M /a/nested/tree
# M /a/nested/tree/1
# M /another
# M /another/whee
# M /another/nested
# M /another/nested/tree
# M /another/nested/tree/1
# M /baz
# M /baz/alink
# M /baz/cow
# M /baz/cowro
# M /baz/saucer
# M /baz/another
# M /baz/another/y
# M /baz/deeper
# M /baz/deeper/ohyeah
# M /baz/deeper/ohyeahx
# M /yet
# M /yet/message
# M /yet/another
# M /yet/another/tree
# M /yet/another/tree/green
File '/tmp/test-tmp-libostree_test-basic-user.sh.test-XAWQA0/diff-test2' is not empty
gpg-connect-agent: no running gpg-agent - starting '/usr/bin/gpg-agent'
gpg-connect-agent: waiting for the agent to come up ... (5s)
gpg-connect-agent: connection to agent established
OK closing connection
FAIL: libostree/test-basic-user.sh.test (Child process exited with code 1)
bfdc5fc4fc84ef8518d2d1a328c8482cf5a38e98 is the first bad commit
commit bfdc5fc4fc84ef8518d2d1a328c8482cf5a38e98
Author: Philip Withnall <withnall@endlessm.com>
Date: Fri Sep 27 17:42:03 2019 +0100
glocalfileinfo: Only return file mode, not type, as UNIX_MODE attribute
As with the previous commit, `st_mode` contains both the file type
(regular file, directory, symlink, special, etc.) and the file mode. For
`G_FILE_ATTRIBUTE_ID_UNIX_MODE`, we only want the file mode — so mask
`st_mode` with `~S_IFMT`.
Signed-off-by: Philip Withnall <withnall@endlessm.com>
:040000 040000 c6aefb396c265ec882a2d5895667cec7e4195dde 8c4fca76b9e68a4f94a8f2943ce1225ffdd4b002 M gio
bisect run success
sure enough reverting that causes the test to start passing again. cc @alexl