Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gjs gjs
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 105
    • Issues 105
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 18
    • Merge requests 18
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • gjsgjs
  • Merge requests
  • !760

Cherrypick gnome-screenshot memleak fix

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Jeremy Bicha requested to merge jbicha/gjs:cherry-pick-screenshot-memleak into gnome-42 Jun 28, 2022
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

GBytes parameters in "transfer none" mode needs to be released after the function returns, otherwise its reference count will be incremented even if the callee doesn't own the reference, causing a memory leak. Fix this by using BoxedInTransferNone::release instead of BoxedIn::release which is a no-op.

Fixes #483 (closed)

(cherry picked from commit f43d9d16)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: cherry-pick-screenshot-memleak