Skip to content

NMake/libgjs-private: Export all the public symbols there

Chun-wei Fan requested to merge export.gjsprivate into master

Hi,

Going a bit further, I won't be that sad if this does not make it into the upcoming stable release... I think there are symbols in libgjs-private that should be also exported in the NMake builds. From the commit message:

It seems that since GjsPrivate-1.0.[gir|typelib] refers to APIs from there, we ought to export those as well for the Visual Studio builds via GJS_EXPORT, so that they can be loaded by the girepository DLL.

It turns out that this portion of the code used to be a DLL/.so of its own, so it also makes sense to export these so that they are available from gjs.lib as well.

With blessings, thank you!

Edited by Chun-wei Fan

Merge request reports