Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
gjs
gjs
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 102
    • Issues 102
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 18
    • Merge Requests 18
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • gjsgjs
  • Merge Requests
  • !114

Merged
Opened Mar 31, 2018 by Georges Basile Stavracas Neto@feaneronDeveloper

Queue a GC when a toggle reference goes from >1 to 1

  • Overview 20
  • Commits 2
  • Pipelines 7
  • Changes 3

This is my hacky approach to the problem. This runs the GC much less than expected but more than what would be acceptable (@chergert's idea make it runs much less than my original approach). But it definitely holds the GNOME Shell memory at the same plateu for a long, long time, helping gnome-shell#64 (closed) not happen.

Some ideas that are worth considering:

  • Use a timeout instead of an idle add (it appearently didn't have the same effectiveness though...)
  • Don't force GC but instead improve the current heuristics
  • What else?

Issue: #140 (closed)

Edited Apr 13, 2018 by Georges Basile Stavracas Neto
Assignee
Assign to
Reviewer
Request review from
GNOME 3.28 bugfixes
Milestone
GNOME 3.28 bugfixes (Past due)
Assign milestone
Time tracking
Reference: GNOME/gjs!114
Source branch: gbsneto/aggressive-gc

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.