Commit details' auto-hyperlinking (of HTTP / HTTPS) is off by one character (or more)
With version 45.alpha
as well as the git version built with GNOME Builder, gitg's parse_links_on_subject
and parse_smart_text
methods in libgitg/gitg-diff-view-commit-details.vala (as implemented by @gaurav1999 in 79a10fbf for issue #152 (closed)) seem to create hyperlinks that are typically off by one character (and sometimes more).
You can see this with the blue underlined portions in the screenshots below; those are all commits from gitg's repository (so you can easily reproduce the problem using gitg's search feature).
ec8d97d5c4913
:
da0e21aa13a
(this one seems to behave in a very special way):
8ef12dc80c
:
79a10fbf8
:
e86a333
(this one seems to behave in a very special way):
Overall, the hyperlinks themselves still work correctly (i.e. they open the correct URL) and even then it used to not have hyperlinks at all, so in practice this is a minor non-urgent cosmetic issue that would be "nice to fix".