Renaming a branch creates a temporary duplicate in the sidebar, instead of renaming in-place
This is a minor GUI issue, but, with version 44 (aka 45.alpha):
- Select a local branch in the sidebar
- Right-click and select "Rename…", give it a new name
Result: the row in the sidebar does not get its row item's label renamed "in place", what actually happens is that it creates a new row with the new name and then removes the old row. This can lead to some race conditions with undesired side-effects:
-
Sometimes, this happens too slowly and you see the old and new branch names as two separate rows for a few seconds until the UI eventually refreshes. For the issue to appear, I think this depends a bit on your "luck" and how busy your computer is..
-
If you try to rename the branch again and keep the renaming field active before gitg refreshed its global views after a few seconds, it will fail, give you an error infobar saying "Invalid name" (
The specified name "" contains invalid characters
), and it puts your modified string into the searchbar.
The trick to reproducing this is: rename,Enter
, rename again but don't validate (don't pressEnter
) so that the editable text field is still active when gitg tries to auto-refresh; then you will get the error infobar below.
Demonstration video of symptom no2 is here (unfortunately I was not able to capture a video of symptom no1, that one is harder to trigger): https://youtu.be/D2c32kuOJfU
A bit similar to #434 but not exactly.