Hardcoded single quotes should be available for translation
The code lines listed below have single quotes (' ') hardcoded replacing placeholders in translation string (e.g. Merge 'master' into branch 'foobar'
). The first issue with this is that it doesn't follow GNOME HIG's Typography, as it should be curvy double quotes (“ ”).
The second issue is that it should be part of the translation string so that the translator can properly translate the quotes to their language. For instance, French would translate to guillemets (« »).
See the list of source files and their respective lines I found in the source code:
gitg/gitg-commit-action-cherry-pick.vala line 199:
var notification = new SimpleNotification(_("Cherry pick %s onto %s").printf(@"'$shortid'", @"'$name'"));
gitg/gitg-commit-action-cherry-pick.vala line 261:
subitem.tooltip_text = _("Cherry pick onto %s").printf(@"'$name'");
gitg/gitg-ref-action-checkout.vala line L72:
var notification = new SimpleNotification(_("Checkout %s").printf(@"'$(reference.parsed_name.shortname)'"));
gitg/gitg-ref-action-merge.vala line 320:
item.tooltip_text = _("Merge %s into branch %s").printf(@"'$name'", @"'$(reference.parsed_name.shortname)'");