3.32.1: build fails with latest vala
Looks like build fails with latest vala 0.49.91.
[20/198] valac -C --vapidir=/home/tkloczko/rpmbuild/BUILD/gitg-3.32.1/vapi --pkg gio-unix-2.0 --pkg libsoup-2.4 --pkg libsecret-1 /home/tkloczko/rpmbuild/BUILD/gitg-3.32.1/contrib/ide/ide.vapi --pkg gtksourceview-4 --pkg gsettings-desktop-schemas /home/tkloczko/rpmbuild/BUILD/gitg-3.32.1/vapi/gitg-platform-support.vapi /home/tkloczko/rpmbuild/BUILD/gitg-3.32.1/vapi/config.vapi --pkg libdazzle-1.0 --pkg libgit2-glib-1.0 --pkg gtk+-3.0 --target-glib ' 2.38' --pkg glib-2.0 --pkg gio-2.0 --pkg gee-0.8 --color=always --directory libgitg/libgitg-1.0.so.0.0.0.p --basedir ../libgitg --library gitg-1.0 --header libgitg/libgitg.h --vapi ../libgitg-1.0.vapi --gir ../Gitg-1.0.gir --gresources=../libgitg/resources/resources.xml ../libgitg/gitg-assembly-info.vala ../libgitg/gitg-async.vala ../libgitg/gitg-authentication-dialog.vala ../libgitg/gitg-avatar-cache.vala ../libgitg/gitg-branch-base.vala ../libgitg/gitg-branch.vala ../libgitg/gitg-cell-renderer-lanes.vala ../libgitg/gitg-color.vala ../libgitg/gitg-commit-list-view.vala ../libgitg/gitg-commit-model.vala ../libgitg/gitg-commit.vala ../libgitg/gitg-credentials-manager.vala ../libgitg/gitg-date.vala ../libgitg/gitg-diff-image-composite.vala ../libgitg/gitg-diff-image-difference.vala ../libgitg/gitg-diff-image-overlay.vala ../libgitg/gitg-diff-image-side-by-side.vala ../libgitg/gitg-diff-image-slider.vala ../libgitg/gitg-diff-image-surface-cache.vala ../libgitg/gitg-diff-selectable.vala ../libgitg/gitg-diff-stat.vala ../libgitg/gitg-diff-view-commit-details.vala ../libgitg/gitg-diff-view-file-info.vala ../libgitg/gitg-diff-view-file-renderer-binary.vala ../libgitg/gitg-diff-view-file-renderer-image.vala ../libgitg/gitg-diff-view-file-renderer-text.vala ../libgitg/gitg-diff-view-file-renderer.vala ../libgitg/gitg-diff-view-file-selectable.vala ../libgitg/gitg-diff-view-file.vala ../libgitg/gitg-diff-view-lines-renderer.vala ../libgitg/gitg-diff-view-options.vala ../libgitg/gitg-diff-view.vala ../libgitg/gitg-hook.vala ../libgitg/gitg-init.vala ../libgitg/gitg-label-renderer.vala ../libgitg/gitg-lanes.vala ../libgitg/gitg-lane.vala ../libgitg/gitg-progress-bin.vala ../libgitg/gitg-ref-base.vala ../libgitg/gitg-ref.vala ../libgitg/gitg-remote.vala ../libgitg/gitg-repository-list-box.vala ../libgitg/gitg-repository.vala ../libgitg/gitg-resource.vala ../libgitg/gitg-sidebar.vala ../libgitg/gitg-stage-status-enumerator.vala ../libgitg/gitg-stage.vala ../libgitg/gitg-theme.vala ../libgitg/gitg-utils.vala ../libgitg/gitg-when-mapped.vala
FAILED: libgitg/libgitg-1.0.so.0.0.0.p/gitg-assembly-info.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-async.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-authentication-dialog.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-avatar-cache.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-branch-base.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-branch.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-cell-renderer-lanes.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-color.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-commit-list-view.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-commit-model.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-commit.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-credentials-manager.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-date.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-image-composite.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-image-difference.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-image-overlay.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-image-side-by-side.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-image-slider.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-image-surface-cache.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-selectable.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-stat.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-commit-details.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-file-info.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-file-renderer-binary.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-file-renderer-image.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-file-renderer-text.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-file-renderer.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-file-selectable.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-file.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-lines-renderer.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view-options.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-diff-view.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-hook.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-init.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-label-renderer.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-lanes.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-lane.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-progress-bin.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-ref-base.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-ref.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-remote.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-repository-list-box.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-repository.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-resource.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-sidebar.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-stage-status-enumerator.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-stage.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-theme.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-utils.c libgitg/libgitg-1.0.so.0.0.0.p/gitg-when-mapped.c libgitg/libgitg.h libgitg/libgitg-1.0.vapi libgitg/Gitg-1.0.gir
valac -C --vapidir=/home/tkloczko/rpmbuild/BUILD/gitg-3.32.1/vapi --pkg gio-unix-2.0 --pkg libsoup-2.4 --pkg libsecret-1 /home/tkloczko/rpmbuild/BUILD/gitg-3.32.1/contrib/ide/ide.vapi --pkg gtksourceview-4 --pkg gsettings-desktop-schemas /home/tkloczko/rpmbuild/BUILD/gitg-3.32.1/vapi/gitg-platform-support.vapi /home/tkloczko/rpmbuild/BUILD/gitg-3.32.1/vapi/config.vapi --pkg libdazzle-1.0 --pkg libgit2-glib-1.0 --pkg gtk+-3.0 --target-glib ' 2.38' --pkg glib-2.0 --pkg gio-2.0 --pkg gee-0.8 --color=always --directory libgitg/libgitg-1.0.so.0.0.0.p --basedir ../libgitg --library gitg-1.0 --header libgitg/libgitg.h --vapi ../libgitg-1.0.vapi --gir ../Gitg-1.0.gir --gresources=../libgitg/resources/resources.xml ../libgitg/gitg-assembly-info.vala ../libgitg/gitg-async.vala ../libgitg/gitg-authentication-dialog.vala ../libgitg/gitg-avatar-cache.vala ../libgitg/gitg-branch-base.vala ../libgitg/gitg-branch.vala ../libgitg/gitg-cell-renderer-lanes.vala ../libgitg/gitg-color.vala ../libgitg/gitg-commit-list-view.vala ../libgitg/gitg-commit-model.vala ../libgitg/gitg-commit.vala ../libgitg/gitg-credentials-manager.vala ../libgitg/gitg-date.vala ../libgitg/gitg-diff-image-composite.vala ../libgitg/gitg-diff-image-difference.vala ../libgitg/gitg-diff-image-overlay.vala ../libgitg/gitg-diff-image-side-by-side.vala ../libgitg/gitg-diff-image-slider.vala ../libgitg/gitg-diff-image-surface-cache.vala ../libgitg/gitg-diff-selectable.vala ../libgitg/gitg-diff-stat.vala ../libgitg/gitg-diff-view-commit-details.vala ../libgitg/gitg-diff-view-file-info.vala ../libgitg/gitg-diff-view-file-renderer-binary.vala ../libgitg/gitg-diff-view-file-renderer-image.vala ../libgitg/gitg-diff-view-file-renderer-text.vala ../libgitg/gitg-diff-view-file-renderer.vala ../libgitg/gitg-diff-view-file-selectable.vala ../libgitg/gitg-diff-view-file.vala ../libgitg/gitg-diff-view-lines-renderer.vala ../libgitg/gitg-diff-view-options.vala ../libgitg/gitg-diff-view.vala ../libgitg/gitg-hook.vala ../libgitg/gitg-init.vala ../libgitg/gitg-label-renderer.vala ../libgitg/gitg-lanes.vala ../libgitg/gitg-lane.vala ../libgitg/gitg-progress-bin.vala ../libgitg/gitg-ref-base.vala ../libgitg/gitg-ref.vala ../libgitg/gitg-remote.vala ../libgitg/gitg-repository-list-box.vala ../libgitg/gitg-repository.vala ../libgitg/gitg-resource.vala ../libgitg/gitg-sidebar.vala ../libgitg/gitg-stage-status-enumerator.vala ../libgitg/gitg-stage.vala ../libgitg/gitg-theme.vala ../libgitg/gitg-utils.vala ../libgitg/gitg-when-mapped.vala
libsoup-2.4.vapi:106.3-106.13: warning: Creation method of abstract class cannot be public.
public Auth (GLib.Type type, Soup.Message msg, string auth_header);
^^^^^^^^^^^
../libgitg/gitg-diff-view-file-selectable.vala:57.45-57.48: error: Argument 1: Cannot pass value to reference or output parameter
while (buffer.forward_iter_to_source_mark(iter, d_selection_category))
^^^^
../libgitg/gitg-diff-view-file-selectable.vala:324.43-324.46: error: Argument 1: Cannot pass value to reference or output parameter
if (!buffer.forward_iter_to_source_mark(iter, "header"))
^^^^
../libgitg/gitg-diff-view-file-selectable.vala:496.25-496.80: warning: Access to possible `null'. Perform a check or use an unsafe cast.
something_selected = (buffer as Gtk.SourceBuffer).forward_iter_to_source_mark(iter, d_selection_category);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../libgitg/gitg-diff-view-file-selectable.vala:496.82-496.85: error: Argument 1: Cannot pass value to reference or output parameter
something_selected = (buffer as Gtk.SourceBuffer).forward_iter_to_source_mark(iter, d_selection_category);
^^^^
../libgitg/gitg-diff-view-file-renderer-text.vala:456.4-456.44: warning: Access to possible `null'. Perform a check or use an unsafe cast.
(buffer as Gtk.SourceBuffer).style_scheme = s;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../libgitg/gitg-diff-view.vala:645.21-645.56: warning: Access to possible `null'. Perform a check or use an unsafe cast.
var selectable = (file as Gitg.DiffViewFile).renderer as DiffSelectable;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../libgitg/gitg-diff-view.vala:947.9-947.44: warning: Access to possible `null'. Perform a check or use an unsafe cast.
if (!(file as Gitg.DiffViewFile).expanded)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../libgitg/gitg-diff-view.vala:248.4-248.39: warning: Access to possible `null'. Perform a check or use an unsafe cast.
(file as Gitg.DiffViewFile).expanded = expanded;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
../libgitg/gitg-diff-view.vala:963.14-963.49: warning: Access to possible `null'. Perform a check or use an unsafe cast.
var sel = (file as Gitg.DiffViewFile).renderer as DiffSelectable;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 3 error(s), 7 warning(s)
ninja: build stopped: subcommand failed.