• Simon Mueller's avatar
    Bug 793722 - Capture screenshot of single window fails if... · 14236761
    Simon Mueller authored
    ... thewindow is IE 11.
    
    The screenshot plugin for windows had a problem when capturing
    applications that use hardware rendering acceleration (e.g.
    Chromium-based Apps, IE11). Those applications seem to render their
    content to a device context (DC) that is different from the one that can
    be retrieved via GetDCEx(hWnd). So a screenshot that simply copies the
    main window DC will be incomplete (see bug attachment) or just plain
    black.
    
    This patch removes the code that uses GetDCEx for single window
    screenshots and always uses the display device context instead. This
    makes sure that all window contents are actually visible in the
    screenshot. With this change, we now have to set the source coordinates
    in the call to BitBlt() to the window's coordinates to exclude
    everything that isn't the window from the screenshot when doing a single
    window screenshot.
    
    Review comment by Jehan: as Simon notes in bug 793722, there is a
    regression though, which is that this new code cannot capture any part
    of a window which is not in any screen. This is still an improvement
    because at least for what is on screen, we always get exactly the same
    as what is displayed. This is especially true since hardware-accelerated
    applications are more and more common. So let's push this first commit
    and hope for further improvements.
    14236761
Name
Last commit
Last update
app Loading commit data...
build Loading commit data...
cursors Loading commit data...
data Loading commit data...
desktop Loading commit data...
devel-docs Loading commit data...
docs Loading commit data...
etc Loading commit data...
icons Loading commit data...
libgimp Loading commit data...
libgimpbase Loading commit data...
libgimpcolor Loading commit data...
libgimpconfig Loading commit data...
libgimpmath Loading commit data...
libgimpmodule Loading commit data...
libgimpthumb Loading commit data...
libgimpwidgets Loading commit data...
m4macros Loading commit data...
menus Loading commit data...
modules Loading commit data...
pdb Loading commit data...
plug-ins Loading commit data...
po Loading commit data...
po-libgimp Loading commit data...
po-plug-ins Loading commit data...
po-python Loading commit data...
po-script-fu Loading commit data...
po-tags Loading commit data...
po-tips Loading commit data...
po-windows-installer Loading commit data...
themes Loading commit data...
tools Loading commit data...
.dir-locals.el Loading commit data...
.gitignore Loading commit data...
.gitmodules Loading commit data...
.kateconfig Loading commit data...
AUTHORS Loading commit data...
COPYING Loading commit data...
ChangeLog.pre-1-0 Loading commit data...
ChangeLog.pre-1-2 Loading commit data...
ChangeLog.pre-2-0 Loading commit data...
ChangeLog.pre-2-2 Loading commit data...
ChangeLog.pre-2-4 Loading commit data...
ChangeLog.pre-2-6 Loading commit data...
ChangeLog.pre-git Loading commit data...
HACKING Loading commit data...
INSTALL.in Loading commit data...
LICENSE Loading commit data...
MAINTAINERS Loading commit data...
Makefile.am Loading commit data...
NEWS Loading commit data...
NEWS.pre-2-0 Loading commit data...
NEWS.pre-2-2 Loading commit data...
NEWS.pre-2-4 Loading commit data...
NEWS.pre-2-6 Loading commit data...
NEWS.pre-2-8 Loading commit data...
README Loading commit data...
README.i18n Loading commit data...
acinclude.m4 Loading commit data...
authors.dtd Loading commit data...
authors.xml Loading commit data...
authors.xsl Loading commit data...
authors4gimp-web.xsl Loading commit data...
autogen.sh Loading commit data...
config.h.win32 Loading commit data...
configure.ac Loading commit data...
gimp-zip.in Loading commit data...
gimp.doap Loading commit data...
gimp.pc.in Loading commit data...
gimpthumb.pc.in Loading commit data...
gimpui.pc.in Loading commit data...