Skip to content

New GimpProcedureDialog API: gimp_procedure_get_size_entry

Alx Sa requested to merge alxsa-gimpproceduredialog-size-entry into master

A lot of plug-ins use GimpSizeEntry. As part of the port, I've added a new function gimp_procedure_get_size_entry() so this can be done through GimpProcedureDialog API instead. The second commit shows an implementation with the border-average plug-in.

@Jehan: Hello! Another question when you have time:

  1. I used the same parameters for this as gimp_prop_size_entry_new (). Do you want any changes to this (e.g. should I set a default GimpSizeEntryUpdatePolicy rather than having that as a parameter)? 2) I was getting a critical message whenever the dialogue opened with GIMP_UNIT_PIXEL set for the units. I added a check in gimppropwidgets.c to prevent gimp_unit_get_scaled_digits () from being called for pixels. I saw your comment here (f705bfb3) and wondered if this was the right place to put that check, or should it go in libgimpbase/gimpunit.c? Resolved after our IRC discussion.
Edited by Alx Sa

Merge request reports