Skip to content

Draft: app: possible fix for #8359 CRITICAL on close dock

Lloyd Konneker requested to merge bootchk/gimp:dockCloseCrash into master

See commit text.

Illustrative only. Fixes a race from signal dock_columns.dock_removed to two connections, gimp_dock_windows_update_title() and gimp_dock_windows_dock_removed(). If the latter wins the race, it destroys the dock_columns owned by dock_windows, and the loser of the race, gimp_dock_windows_update_title, references the destroyed object at dock_windows->p->dock_columns.

Should be backported to 2.10 ?

I am still not sure this causes any harm unless G_DEBUG=fatal_criticals. On Windows, is a CRITICAL an unhandled exception, always?

Also, #8359 (closed) as originally reported may be unrelated, I might have camped on that thread.

Merge request reports