Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • GIMP GIMP
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 3,823
    • Issues 3,823
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 92
    • Merge requests 92
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GIMPGIMP
  • Merge requests
  • !534

gtk3to4: upgrade from depr device_grab to seat grab which is a deprecation action

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Lukas Oberhuber requested to merge lukaso/gimp:master into master Dec 27, 2021
  • Overview 34
  • Commits 1
  • Pipelines 41
  • Changes 3

Migrates from the deprecated gdk_device_grab API to the new gdk_seat_grab API.

https://docs.gtk.org/gtk4/migrating-3to4.html#stop-using-gdkdevicemanager

There is code (at least for the keyboard version) that checks if the device has changed. This code had to be removed due to the API changes. Given this functionality has been deprecated by Gtk and is fully removed in Gtk4, I feel this is the right thing to do.

Other

It is unlikely that functionality has been lost given the deprecation.

My sense is that the keyboard device change adjustments were catering to multiple keyboards. In any case, all the code is now run all the time instead of only when a device change was detected. This might have a slight performance hit, but unknown. Though nothing has come up in the performance tests.

Edited Jan 08, 2022 by Lukas Oberhuber
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master