Skip to content

app: lower the upper limit for feather selection

Anders Jonsson requested to merge ajonsson/gimp:feather-limits into master

Found one more limit problem.

This fixes criticals caused by setting Feather selection by to more than 5250 in Select->Feather...

E.g on setting the value to 32767 (current max in dialog):

(gimp-2.99:12450): GLib-GObject-CRITICAL **: 20:30:03.506: value "9362.000000" of type 'gdouble' is invalid or out of range for property 'std-dev-x' of type 'gdouble'

(gimp-2.99:12450): GLib-GObject-CRITICAL **: 20:30:03.506: value "9362.000000" of type 'gdouble' is invalid or out of range for property 'std-dev-y' of type 'gdouble'

The reason for that specific max value is that it calls gaussian blur in Gegl which has max value 1500, after first having been divided by a magic number 3.5 in https://gitlab.gnome.org/GNOME/gimp/-/blob/master/app/gegl/gimp-gegl-apply-operation.c#L446, so real max is 1500*3.5

Merge request reports