Skip to content

libgimpwidgets: Port GimpPickButton to GeglColor

Alx Sa requested to merge alxsa-pick-button-gegl-color into master

This patch attempts to replace GimpRGB with GeglColor in the various platform's GimpPickButton implementations. It also sends a GeglColor when the "color-picked" signal is emitted instead of GimpRGB.

@Jehan: Hi! When you have some time, I had a few questions:

  • Is this the correct way to send a GeglColor when a signal is emitted (by passing it via the signal and then unreferencing it in the receiving function)?
  • Is my understanding correct that we no longer need to call gimp_color_transform_process_pixels () to convert RGBA values from the monitor profile to sRGB, but instead can just get the space from the monitor profile and then set it in the GeglColor with gegl_color_set_rgba_with_space ()?

Merge request reports