Skip to content

NDE: Fix Threshold editing glitch

Alx Sa requested to merge alxsa-nde-threshold-fix into master

Before merging !958 (merged), @Jehan mentioned at least one outstanding bug - the Threshold filter does not carry over its original values when being edited as an NDE filter.

Most filters use the standard GEGL Operation Tool dialogue, and their properties are copied over on set-up. Some GIMP-specific custom operations use a GimpConfig for their settings, and that's copied over in gimp_filter_tool_set_config ().

The Threshold tool is different - it's a custom GIMP operation that doesn't use GimpConfig, so it's not covered by either case. This patch proposes to fix it by adding an ELSE condition to the code in gimpgeglprocedure.c that copies over the GimpConfig object, and copies the individual properties instead. This should work both for Threshold and also any future tool that meets this criteria.

Feedback welcome!

Edited by Alx Sa

Merge request reports