Skip to content

Draft: libgimpwidgets: remove deprecated warning for gtk_icon_theme_add_builtin_icon

Jacob Boerema requested to merge wip/wormnest/deprecated-add-builtin-icon into master

Removing this code seems to work fine for me with all three icon themes. An easy way to test, is menu View -> Move to Screen -> Open Display.

Since I am not that familiar with icon theme related handling I'd prefer others to have a look before merging this. Maybe I am overlooking something.

My first thought was replacing the code with

  gtk_icon_theme_add_resource_path (gtk_icon_theme_get_default (),
                                    "/org/gimp/icons/64/gimp-wilber-eek.png");

That works too, but if like it seems that is not needed, we should probably remove it all, and that's what I opted for in this MR.

--

gtk_icon_theme_add_builtin_icon has been deprecated since GTK 3.14, it recommends replacing with: gtk_icon_theme_add_resource_path.

After testing, it seems our gimp-wilber-eek icon works even without using this replacement. So, we just remove all code that explicitly sets our gimp-wilber-eek icon.

Merge request reports

Loading