app/widgets crash on close dock window in multiwindow mode
To reproduce, get in multiwindow mode, with Font dock closed, and open then close the Fonts dock from the Fonts popup in the Toolbox options:
-
Choose Menubar>Window. Expect a menu to appear. In the menu, uncheck the "Single-Window Mode" checkbox. If you were in single window mode, expect the windows to break apart.
-
In the dock, if the font selection widget is a tab, bring the tab to the front, then click left mouse button LMB on the icon (a left arrow) at the far right of the tab bar. Expect a popup menu to appear. In the menu choose "Close Tab". Expect the font selection widget to dissappear from the dock.
-
In the "Toolbox-Tool Options" widget, LMB click on the text tool icon (a big "A"). Expect the lower half of the widget to show the text tool options.
-
LMB click on the icon that looks like "Aa". Expect a popup menu showing a list of font names and other buttons at the bottom.
-
In the lower right of the popup, LMB click on the icon that looks like "abc" and whose tooltip is "Open the font selection dialog." Expect a "Fonts" dialog to appear in a new window. (Except known to fail on Windows see 8359)
-
In the "Fonts" dialog, LMB click on the close dialog icon (the red "X" icon) in the upper right. Expect Fonts window to close.
Actual: GIMP crash. The console shows:
(gimp-2.99:42): Gimp-Widgets-CRITICAL **: 11:58:27.041: gimp_dock_columns_get_docks: assertion 'GIMP_IS_DOCK_COLUMNS (dock_columns)' failed
Happens in 2.99 on Windows and Linux, unknown on MacOS.
Probably also in 2.10.
Discovered while debugging #8359 (closed), but that is different, opening versus closing dock windows.
I did a cursory diff 2.10 to master of the pertinent file app/widgets/gimpdockwindow.c and didn't see substantive differences surrounding what I think is the problem.
I will submit an MR soon.