GimpImageWindow does not call parent's window_state_event()
Environment/Versions
- GIMP version: 2.96 (git, master branch)
- Package: built from sources
- Operating System: Linux
Description of the bug
Gimp's main window does not update it's CSS classes when maximized/minimized/tiled etc. as described in GTK3 docs.
This is needed for such GNOME-Shell extensions as "Pixel Saver", "Unite" and similar ones to determine maximized windows. Anyway it is expected behavior for all GTK3-based apps.
Reproduction
Is the bug reproducible?
Reproduction steps:
- Launch GIMP with GtkInspector
- Make it full screen
- See GimpImageWindow style classes in Node Inspector
For example, when window is maximized, GtkInspector shows (actual result):
At least there is no ".maximized" class as well as ".tiled-*" and some others. That is how it should be (expected result):
Additional information
It happens because of overridden GimpImageWindow::window_state_event
in app/display/gimpimagewindow.c
. It does not call parent event handler which performs updating style classes (GtkWindow::update_window_style_classes
).
I will provide merge request that fixes it.