macOS language bug in gettext
GIMP version: 2.10.2
Operating System: macOS
Package: test DMG package we uploaded a few days ago
Description of the bug
We used to have a pretty bad language bug. It has been diagnosed as a gettext bug, and a patch was submitted upstream (no idea if it got merged in the end).
@kristian (who was doing previous DMGs) had a patch for this: https://gitlab.gnome.org/GNOME/gimp/blob/gimp-2-8/build/osx/patches/gettext-fix-English-fallback-for-macOS-Sierra.patch
See commit f2e483df. Old report: https://bugzilla.gnome.org/show_bug.cgi?id=770708#c46
Apparently (according to someone on Twitter), the bug is back, so I am assuming we haven't applied this patch on the gettext packaged in the DMG. Could we please check, and if confirmed, could we fix before the installer is made stable. This used to be a pretty bad bugs which had a lot of reports.
Also as a general rule, could we check the list of patches which Kris used to gather for the macOS build and check if they still need to be applied? We should rely on older work to prevent regressions.