Regression: Cannot drag&drop color from palette to GEGL dialog color selector
Environment/Versions
- GIMP version: e927b6c4 (current master)
- Package: compiled from source
- Operating System: Linux
Description of the bug
Drag&drop from the palette to a GEGL dialog color selector does not work any more.
Reproduction
Is the bug reproducible? Always
Reproduction steps:
- Create a new image
- Colors -> Color to alpha...
- Drag the foreground color onto the "Color" selector.
Expected result: The color in the color selector is replaced by the foreground color.
Actual result: The Gimp debug dialog appears with a message: "GIMP encountered an error: GIMP-WARNING: gimp_color_area_drag_data_received: received invalid color data". After closing the dialog, the color in the color selector stays the same.
Additional information
The issue was introduced in commit bab9ed18 ("app: color drag'n drop is now space-invaded").
In that commit, the selection handling code was adapted in app/widgets/gimpselectiondata.c
, but not in libgimpwidgets/gimpcolorarea.c
.
Backtrace:
#0 0x00007f020d505dcc in read () at /lib64/libc.so.6
#1 0x00007f020f043843 in gimp_stack_trace_print () at /lib64/libgimpbase-3.0.so.0
#2 0x00005636f6d39e0d in gui_message(Gimp*, GObject*, GimpMessageSeverity, gchar const*, gchar const*) (gimp=0x5636f7b26440, handler=0x0, severity=GIMP_MESSAGE_BUG_WARNING, domain=0x5636f6f7e02d "GIMP", message=0x5636fbba2e20 "gimp_color_area_drag_data_received: received invalid color data") at ../app/gui/gui-message.c:141
trace = 0x0
gen_trace = 1
#3 0x00005636f6b82f42 in gimp_show_message(Gimp*, GObject*, GimpMessageSeverity, gchar const*, gchar const*) (gimp=0x5636f7b26440, handler=0x0, severity=GIMP_MESSAGE_BUG_WARNING, domain=0x5636f6f7e02d "GIMP", message=0x5636fbba2e20 "gimp_color_area_drag_data_received: received invalid color data") at ../app/core/gimp-gui.c:160
desc = 0x5636f6f91a4a "Message"
__func__ = "gimp_show_message"
#4 0x00005636f6cf9793 in gimp_message_log_func (log_domain=0x7f020ec6e014 "LibGimpWidgets", flags=<optimized out>, message=0x5636fbba2e20 "gimp_color_area_drag_data_received: received invalid color data", data=0x5636f7b26440) at ../app/errors.c:263
gimp = 0x5636f7b26440
config = 0x5636f7c5aad0
msg_domain = 0x0
severity = <optimized out>
gui_message = <optimized out>
debug_policy = GIMP_DEBUG_POLICY_WARNING
#5 0x00007f020e9e7340 in g_logv () at /lib64/libglib-2.0.so.0
#6 0x00007f020e9e75ef in g_log () at /lib64/libglib-2.0.so.0
#7 0x00007f020daa0391 in () at /lib64/libgtk-3.so.0
#8 0x00007f020ef59661 in () at /lib64/libgobject-2.0.so.0
#9 0x00007f020ef6e0e4 in () at /lib64/libgobject-2.0.so.0
#10 0x00007f020ef73f9e in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
#11 0x00007f020dd7cbc8 in () at /lib64/libgtk-3.so.0
#12 0x00007f020da9e632 in () at /lib64/libgtk-3.so.0
#13 0x00007f020ef59661 in () at /lib64/libgobject-2.0.so.0
#14 0x00007f020ef6e0e4 in () at /lib64/libgobject-2.0.so.0
#15 0x00007f020ef73f9e in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0
#16 0x00007f020dc853b5 in gtk_selection_convert () at /lib64/libgtk-3.so.0
#17 0x00007f020dd7f886 in () at /lib64/libgtk-3.so.0
#18 0x00007f020dbf96d7 in gtk_main_do_event () at /lib64/libgtk-3.so.0
#19 0x00007f020d93e267 in () at /lib64/libgdk-3.so.0
#20 0x00007f020d993252 in () at /lib64/libgdk-3.so.0
#21 0x00007f020e9dcf30 in () at /lib64/libglib-2.0.so.0
#22 0x00007f020e9deb58 in () at /lib64/libglib-2.0.so.0
#23 0x00007f020e9df20c in g_main_context_iteration () at /lib64/libglib-2.0.so.0
#24 0x00007f020e78554d in g_application_run () at /lib64/libgio-2.0.so.0
…