• Michael Natterer's avatar
    Initial space invasion commit in GIMP · e09e563a
    Michael Natterer authored
    All babl formats now have a space equivalent to a color profile,
    determining the format's primaries and TRCs. This commit makes GIMP
    aware of this.
    - enum GimpPrecision: rename GAMMA values to NON_LINEAR and keep GAMMA
      as deprecated aliases, add PERCEPTUAL values so we now have LINEAR,
      NON_LINEAR and PERCPTUAL for each encoding, matching the babl
      encoding variants RGB, R'G'B' and R~G~B~.
    - gimp_color_transform_can_gegl_copy() now returns TRUE if both
      profiles can return a babl space, increasing the amount of fast babl
      color conversions significantly.
    - TODO: no solution yet for getting libgimp drawable proxy buffers in
      the right format with space.
    - follow the GimpPrecision change.
    - TODO: everything else unchanged and partly broken or sub-optimal,
      like setting a new image's color profile too late.
    - add enum GimpTRCType { LINEAR, NON_LINEAR, PERCEPTUAL } as
      replacement for all "linear" booleans.
    - change gimp-babl functions to take babl spaces and GimpTRCType
      parameters and support all sorts of new perceptual ~ formats.
    - a lot of places changed in the early days of goat invasion didn't
      take advantage of gimp-babl utility functions and constructed
      formats manually. They all needed revisiting and many now use much
      simpler code calling gimp-babl API.
    - change gimp_babl_format_get_color_profile() to really extract a
      newly allocated color profile from the format, and add
      gimp_babl_get_builtin_color_profile() which does the same as
      gimp_babl_format_get_color_profile() did before. Visited all callers
      to decide whether they are looking for the format's actual profile,
      or for one of the builtin profiles, simplifying code that only needs
      builtin profiles.
    - drawables have a new get_space_api(), get_linear() is now get_trc().
    - images now have a "layer space" and an API to get it,
      gimp_image_get_layer_format() returns formats in that space.
    - an image's layer space is created from the image's color profile,
      change gimpimage-color-profile to deal with that correctly
    - change many babl_format() calls to babl_format_with_space() and take
      the space from passed formats or drawables
    - add function gimp_layer_fix_format_space() which replaces the
      layer's buffer with one that has the image's layer format, but
      doesn't change pixel values
    - use gimp_layer_fix_format_space() to make sure layers loaded from
      XCF and created by plug-ins have the right space when added to the
      image, because it's impossible to always assign the right space upon
      layer creation
    - "assign color profile" and "discard color profile" now require use
      of gimp_layer_fix_format_space() too because the profile is now
      embedded in all formats via the space.  Add
      gimp_image_assign_color_profile() which does all that and call it
      instead of a simple gimp_image_set_color_profile(), also from the
      PDB set-color-profile functions, which are essentially "assign" and
      "discard" calls.
    - generally, make sure a new image's color profile is set before
      adding layers to it, gimp_image_set_color_profile() is more than
      before considered know-what-you-are-doing API.
    - take special precaution in all places that call
      gimp_drawable_convert_type(), we now must pass a new_profile from
      all callers that convert layers within the same image (such as
      image_convert_type, image_convert_precision), because the layer's
      new space can't be determined from the image's layer format during
      the call.
    - change all "linear" properties to "trc", in all config objects like
      for levels and curves, in the histogram, in the widgets. This results
      in some GUI that now has three choices instead of two.
      TODO: we might want to reduce that back to two later.
    - keep "linear" boolean properties around as compat if needed for file
      pasring, but always convert the parsed parsed boolean to
    - TODO: the image's "enable color management" switch is currently
      broken, will fix that in another commit.
file-import.c 3.31 KB