Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • Geary Geary
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 464
    • Issues 464
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 36
    • Merge requests 36
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • GearyGeary
  • Merge requests
  • !566

ConversationWebView: Fix crash performing find in conversation

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael Gratton requested to merge mjog/fix-find-crash into mainline Aug 29, 2020
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

WebKit.FindController seems to be signalling found/not-found/cancelled signals multiple times when typing text in the find entry (perhaps when not found and cancelled due to the next keystroke?), causing the async call to be resumed more than once and thus triggering a vala assertion ensuring that doesn't happen.

This commit adds guards so that once the method has resumed once, it is not resumed again.

Fixes #762 (closed)

Edited Aug 29, 2020 by Michael Gratton
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: mjog/fix-find-crash