Skip to content

ConversationWebView: Fix crash performing find in conversation

Michael Gratton requested to merge mjog/fix-find-crash into mainline

WebKit.FindController seems to be signalling found/not-found/cancelled signals multiple times when typing text in the find entry (perhaps when not found and cancelled due to the next keystroke?), causing the async call to be resumed more than once and thus triggering a vala assertion ensuring that doesn't happen.

This commit adds guards so that once the method has resumed once, it is not resumed again.

Fixes #762 (closed)

Edited by Michael Gratton

Merge request reports