Geary.Db.Statement signal "resetted" is ungrammatical
src/engine/db/db-statement.vala
contains a declaration that class Geary.Db.Statement
emits a signal named resetted
. The past tense in english of reset
is also reset
, not resetted
.
I know that reset
is the verb (an action you take), and also already member function of the class under the name reset
, so i think i understand why you've made this choice. The only other option i can think of would be something like was_reset
or on_reset
, both of which don't align with other signal names, like bindings_cleared
or executed
.
Anyway, the term resetted
triggers two spurious "informational" warnings in debian's lintian
:
I: geary: spelling-error-in-binary usr/lib/x86_64-linux-gnu/geary/libgeary-client-3.36.so resetted reset
I: geary: spelling-error-in-binary usr/lib/x86_64-linux-gnu/geary/web-extensions/libgeary-web-process.so resetted reset
I'm happy to override these lintian warnings if you aren't interested in making any changes here (and if you've got external code that depends on these signal names, that's yet another good reason -- i don't know whether such code exists).
Sorry to expose you to this kind of trivia, just wanted to give you a heads-up.
If you want to close this ticket saying "yep, that's what we've got" that's fine with me, i just want it documented.