"Always show from sender" does not persist
I'm running Geary built from git mainline on Ubuntu 20.10.
When Geary hides remote images in a message, if I click "Always show from sender" then the messages appear. However Geary does not remember this, so if I leave the message and come back to it then the messages are hidden again.
This is a recent regression. I performed a 'git bisect', and found that this broke here:
6a0ad7218249e8f5b6ab13840ea973a8270bd4fb is the first bad commit
commit 6a0ad7218249e8f5b6ab13840ea973a8270bd4fb
Author: Michael Catanzaro <mcatanzaro@gnome.org>
Date: Thu Mar 4 17:25:41 2021 -0600
web-process-extension: register GearyWebExtension JS in the right place
We need to register our JS when the window-object-cleared signal is
emitted. Previously we did this when the WebPage object is created, but
this only worked due to luck. Since WebKit r271642, it no longer works.
window-object-cleared is emitted right after page-created, meaning that
right after Geary registers its JS, it all gets wiped away. Oops.
Fixes #1168
src/client/web-process/web-process-extension.vala | 57 ++++++++++++-----------
1 file changed, 31 insertions(+), 26 deletions(-)