gcr-ssh-agent is missing fixes from gnome-keyring-daemon
In February 2021, !67 (merged) copied the entire "ssh" component from gnome-keyring-daemon into gcr as gcr-ssh-agent as part of a plan to remove that code from gnome-keyring entirely. Unfortunately, two years have gone by without that happening, and, in that time, there have been at least two correctness or memory safety fixes to the gnome-keyring-daemon copy of the code that haven't made it into the gcr-ssh-agent copy:
Those should clearly be ported over, but the more important thing I want to highlight is that having two copies of the same code for this long creates confusion about which is the source of truth and results in fixes being applied inconsistently. Until whatever's blocking the deletion of the code in gnome-keyring-daemon gets resolved, perhaps it would be prudent to add automated MR lints, notices in the code, and/or notices in the READMEs of both gnome-keyring-daemon and gcr that alert contributors to the presence of the other copy.
cc @dueno