GitLab

I just realized (when pushing changes into Fedora rawhide) that tests/lib/eds/test-case.vala requires changes due to addressbook service name being changed. The change can be as simple as this:

diff -up folks-0.12.1/tests/lib/eds/test-case.vala.eds-libebook-api folks-0.12.1/tests/lib/eds/test-case.vala
--- folks-0.12.1/tests/lib/eds/test-case.vala.eds-libebook-api	2019-05-21 15:13:42.605790004 +0200
+++ folks-0.12.1/tests/lib/eds/test-case.vala	2019-05-21 15:14:03.266789718 +0200
@@ -123,6 +123,7 @@ public class EdsTest.TestCase : Folks.Te
         };
       const string address_book_services[] =
         {
+          "org.gnome.evolution.dataserver.AddressBook10",
           "org.gnome.evolution.dataserver.AddressBook9",
           "org.gnome.evolution.dataserver.AddressBook8",
           "org.gnome.evolution.dataserver.AddressBook7",

but I'd rather propose to rely on the eds folks had been built with, which means to get the service names from the evolution-data-server-1.2.pc with:

    pkg-config evolution-data-server-1.2 --variable=addressbookdbusservicename
    pkg-config evolution-data-server-1.2 --variable=sourcesdbusservicename

which scales much better than hard coded service names.

I would propose a patch for it, but I've no idea how to achieve that with meson (which is another reason why the simple change above is pasted only as a text, not as a real patch, nor a merge request being opened instead of this bug).