Skip to content

shell: Don't copy whole files from remote shares

Bastien Nocera requested to merge wip/hadess/faster-smb-pdfs into main

We don't need to copy whole files from non-local files unless we can't seek around the file easily, such as for files on HTTP(S) servers.

Consider that files that can be accessed through FUSE can be seeked around and don't need caching.

This makes loading large PDFs from a local Samba share instantaneous.

Note:

  • If some types of remote shares aren't usable, such as sftp, then we can block those rather easily.
  • It won't make CBZ files faster to open because there's still a problem in libarchive doing too much work, and comics files in general seem to need to wait until every page metadata is loaded to show anything.

Merge request reports