Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • evince evince
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 735
    • Issues 735
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 48
    • Merge requests 48
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • evinceevince
  • Merge requests
  • !455

shell: Use composite template for EvToolbar and derive from GtkBin

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Pablo Correa Gomez requested to merge pabloyoyoista/evince:gtk4-preparation-ev-toolbar into main Mar 29, 2022
  • Overview 9
  • Commits 4
  • Pipelines 6
  • Changes 11

This MR has two goals:

  • Help with the porting of EvToolbar to GTK4 by:
    • Using composite templates as the most recent MRs (I hope that is actually a goal and not just something I have wrongly inferred 😄).
    • Deriving EvToolbar from GtkBin instead of HdyHeaderBar. I saw in !373 that this was a problem, and the commit that removed the toolbar is skipped in wip/gpoo/gtk4-rebase-port. With this, the port should by simple possible using AdwBin and AdwHeaderBar.
  • Simplify the code that does the toolbar setup. I have some other code locally which aims to make it possible for evince to work in very narrow displays (e.g: mobile phones) by relocating some widgets from the toolbar at the bottom and using the composite templates really help.

Unfortunately, I had problems adding the EvZoomAction to the composite template, because its properties currently need to be set at construct time. This does not seem possible with the template, which first create the widgets and then sets properties.

The option I could think of is to remove G_PARAM_CONSTRUCT_ONLY and move the initialization of properties to the first time they are set. But I wasn't sure this should be the desired approach, hence, I have marked the MR as draft.

Edited Apr 17, 2022 by Pablo Correa Gomez
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: gtk4-preparation-ev-toolbar